Re: 32-bit profiling counts?

[arnold]

"Andrew J. Schorr" <aschorr@telemetry-investments.com> wrote:

> On Mon, Jun 08, 2020 at 01:22:13PM -0600, arnold@skeeve.com wrote:
> > I went with long long. :-)  The patch will get pushed to the repo
> > shortly.
>
> That was brave. :-) But unless I'm confused, you missed at least one
> printf format here:
>
> profile.c:1046:                         fprintf(prof_fp, " # %ld", 
> ip1->exec_count);

Good catch. Fixed.

> Also, here's another thought: if you're going to dive in and make this
> change, might it be safer to apply the attached patch?
> This way, we leave the other uses of dl unchanged and switch
> only exec_count to use long long. I'm not sure it matters, but it seems
> a bit less risky. And why incur a potential performance hit for the
> other uses of dl? It passes "make check" and "make valgrind".

Did that.  Everything pushed.

Thanks!

Arnold