[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gama] CMake Integration

From: Greg Troxel
Subject: Re: [Bug-gama] CMake Integration
Date: Sun, 20 Oct 2019 20:04:48 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (berkeley-unix)

I should explain one of my comments further.

In auto*, the notion is that the configure code should test for a
feature, such as a library existing, or a header, or if some sample code
can be compiled.  None of this should ask "what OS am I on", so that
when it's built on a not previously contemplated OS, it just works.

cmake may have the same notion.    But almost always when I deal with
packages that have cmake build systems and that do not actually build (on
the system I am building them on), I see a lot of conditionals about OS

So I'd say that if the cmake code has "if this is a mac, do X", or
similar, that's a bug and should be removed, in favor of a feature test.

Of course, another view is that the cmake build should be only for
windows, in which case

if this os is not windows
  throw an error

is a good approach.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]