[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Column labels with --full

From: Erik Auerswald
Subject: Re: Column labels with --full
Date: Tue, 7 Jun 2022 13:41:52 +0200

Hey Tim,

On Mon, Jun 06, 2022 at 10:10:12PM +0000, Tim Rice wrote:
> [...]
> >You are adjusting some test inputs (e.g., exp_sort_in_header_full
> >in tests/datamash-sort-header.sh) in a way that seems unrelated
> >to the --full deprecation.  IMHO that makes it harder to review
> >the changes.
> Well, those changes are for the output, not the input, because
> datamash-sort-header.sh is set up differently to the other tests.
> [...]

Thanks for the explanation!  So the output changed because the operation
changed to another one that works fine with --full.

IMHO it would be better to keep the existing test inputs (including the
operations) and only adjust the expected outputs for the new behavior.
Thus I think it might be better to additionally capture STDERR and add
the deprecation message to the expected output.  That would clearly show
what use is problematic and therefore deprecated.

Adding new tests that check both that use of --full makes sense, works
correctly, and does not produce the deprecation message, is good, too.

Both of the above show the intent behind the change.  The former shows
what does not work well and thus shall be deprecated.  The latter show
what works well and shall be kept.

It seems as if all tests in tests/datamash-sort-header.sh that use --full
check deprecated behavior.  It even seems that most tests with --full
check to be deprecated behavior.  As such it might make sense to add
tests that do check for useful --full behavior with per-line operations.

> [...]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]