[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] stdbuf work in progress
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] stdbuf work in progress |
Date: |
Tue, 9 Jun 2009 12:36:30 +0100 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
Jim Meyering wrote:
> Pádraig Brady wrote:
>> Latest iteration of stdbuf command.
>>
>> Notes:
>> * It installs an unversioned shared lib to PKGLIBDIR
>> (/usr/local/lib/coreutils by default). This is searched
>> for by stdbuf itself rather than relying on the system,
>> which allows us to select the uninstalled lib alongside
>> the stdbuf binary when running tests for example.
>> * Controlling fully buffered mode doesn't work with glibc-2.7:
>> http://sources.redhat.com/bugzilla/show_bug.cgi?id=10108
>> * It only installs to ELF systems with GCC currently
>> (I'm not using libtool at present).
>>
> ...
> Thanks for all the work.
> Preliminary, superficial, feedback:
>
> - adjust spacing before parens, e.g.,
>
> > + free(libstdbuf);
> > +
> > + ret = putenv(LD_PRELOAD);
>
> easiest for new files like this is just to filter though "indent
> --no-tabs"
fixed (lots more of that sorry).
>
> - don't use // comment introducer. Here's one; there are others:
>
> > +#define LIB_NAME "libstdbuf.so" //FIXME: don't hardcode
also fixed
>
> - Ewww. use ASCII apostrophe, not multi-byte in texi source:
>
> > +don\342\200\231t use streams for I/O, and are thus unaffected.
Eek. I must have copied and pasted from the output of man.
cheers,
Pádraig.
- Re: [PATCH] stdbuf work in progress, Pádraig Brady, 2009/06/09
- Re: [PATCH] stdbuf work in progress, Jim Meyering, 2009/06/09
- Re: [PATCH] stdbuf work in progress,
Pádraig Brady <=
- Re: [PATCH] stdbuf work in progress, Jim Meyering, 2009/06/09
- Re: [PATCH] stdbuf work in progress, Pádraig Brady, 2009/06/09
- Re: [PATCH] stdbuf work in progress, Pádraig Brady, 2009/06/10
- Re: [PATCH] stdbuf work in progress, Eric Blake, 2009/06/10
- Re: [PATCH] stdbuf work in progress, Jim Meyering, 2009/06/11
- Re: [PATCH] stdbuf work in progress, Pádraig Brady, 2009/06/11
- Re: [PATCH] stdbuf work in progress, Pádraig Brady, 2009/06/12
- Re: [PATCH] stdbuf work in progress, Jim Meyering, 2009/06/13
- Re: [PATCH] stdbuf work in progress, Pádraig Brady, 2009/06/15
- Re: [PATCH] stdbuf work in progress, Jim Meyering, 2009/06/16