bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] stdbuf work in progress


From: Pádraig Brady
Subject: Re: [PATCH] stdbuf work in progress
Date: Tue, 9 Jun 2009 18:50:04 +0100
User-agent: Thunderbird 2.0.0.6 (X11/20071008)

These 2 hunks are also required to stop check-AUTHORS
causing a silent coredump and to no exclude libstdbuf.c
from the sc_tight_scope check:

diff --git a/src/Makefile.am b/src/Makefile.am
index 85a3841..816ab80 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -405,6 +405,7 @@ check-AUTHORS: $(all_programs)
          && { echo "$@: skipping this check"; exit 0; }; \
        rm -f $(au_actual) $(au_dotdot);                \
        for i in `ls $(all_programs) | sed -e 's,$(EXEEXT)$$,,' \
+           | sed /libstdbuf/d                          \
            | $(ASSORT) -u`; do                         \
          test "$$i" = '[' && continue;                 \
          exe=$$i;                                      \
@@ -437,8 +438,7 @@ sc_tight_scope: $(bin_PROGRAMS)
        $(AM_V_GEN)t=exceptions-$$$$;                                   \
        trap "s=$$?; rm -f $$t; exit $$s" 0 1 2 13 15;                  \
        src=`for f in $(SOURCES); do                                    \
-              test -f $$f && d= || d=$(srcdir)/;                       \
-              test $$f = libstdbuf.c || echo $$d$$f; done`;            \
+              test -f $$f && d= || d=$(srcdir)/; echo $$d$$f; done`;   \
        hdr=`for f in $(noinst_HEADERS); do                             \
               test -f $$f && d= || d=$(srcdir)/; echo $$d$$f; done`;   \
        ( printf 'main\nusage\n_.*\n';                                  \

Also in this file I was wondering about the check-duplicate-no-install: target
It looks like it needs a `sort` but when you add that you notice
that "su" is in both no_install__progs and build_if_possible__progs
(and by consequence EXTRA_PROGRAMS). So I'm unsure of whether the
test is valid or if it is what it's actually checking.
In essence I'm confused as how build_if_possible__progs is used.

cheers,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]