[Bug gas/18574] New: gas/config/tc-msp430.c: 9 * Redundant condition

[dcb314 at hotmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18574

            Bug ID: 18574
           Summary: gas/config/tc-msp430.c: 9 * Redundant condition
           Product: binutils
           Version: 2.26 (HEAD)
            Status: NEW
          Severity: minor
          Priority: P2
         Component: gas
          Assignee: unassigned at sourceware dot org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

1.

[binutils-gdb/gas/config/tc-msp430.c:2072]: (style) Redundant condition:
!op1.reg. 'A && (!A || B)' is equivalent to 'A || B'

Source code is

  else if (op1.reg || (op1.reg == 0 && op1.am == 3))    /* Not PC relative.  */

Maybe better code

  else if (op1.reg || op1.am == 3)    /* Not PC relative.  */

Same thing at lines 2158, 2204, 2274, 2802, 2848, 2950, 2981

Also

gas/config/tc-msp430.c:3326]: (style) Redundant condition: fixp.fx_addsy. 'A &&
(!A || B)' is equivalent to 'A || B'

Source code is

     if (!fixp->fx_addsy || (fixp->fx_addsy
      && S_GET_SEGMENT (fixp->fx_addsy) == absolute_section))

-- 
You are receiving this mail because:
You are on the CC list for the bug.