Re: [GNU Autoconf 2.67] testsuite: 199 246 failed

[Ralf Wildenhues]

Hi Bob,

* Bob Friesenhahn wrote on Tue, Aug 03, 2010 at 11:36:02PM CEST:
> Several tests unexpectedly failed under Solaris 10.  The
> tests/testsuite.log is attached.

thanks for the report.  Here's the first failure:

| 246. torture.at:1708: testing Non-literal AC_CONFIG_SUBDIRS ...
| /home/bfriesen/src/gnu/autoconf-2.67/tests/torture.at:1712: aclocal --version 
|| exit 77
| stderr:
| stdout:
| aclocal (GNU automake) 1.11
| Copyright (C) 2009 Free Software Foundation, Inc.
[...]
| /home/bfriesen/src/gnu/autoconf-2.67/tests/torture.at:1737: autoreconf 
-Werror -v
| stderr:
| autoreconf: Entering directory `.'
| autoreconf: configure.in: not using Gettext
| autoreconf: running: aclocal --warnings=error 
| /usr/local/share/aclocal/xmms.m4:17: warning: underquoted definition of 
XMMS_TEST_VERSION
| /usr/local/share/aclocal/xmms.m4:17:   run info '(automake)Extending aclocal'
| /usr/local/share/aclocal/xmms.m4:17:   or see 
http://sources.redhat.com/automake/automake.html#Extending-aclocal
| autoreconf: aclocal failed with exit status: 1
| stdout:
| /home/bfriesen/src/gnu/autoconf-2.67/tests/torture.at:1738: grep 
'AC_CONFIG_SUBDIRS:.*literals' stderr
| stdout:
| /home/bfriesen/src/gnu/autoconf-2.67/tests/torture.at:1738: exit code was 1, 
expected 0
| 246. torture.at:1708: 246. Non-literal AC_CONFIG_SUBDIRS (torture.at:1708): 
FAILED (torture.at:1738)

This is a testsuite bug: it should not trip over a quoting bug in some
third-party macro file you have installed.  OK to fix Autoconf as below?

But please do fix that xmms.m4 file to not have underquoted macros.

Thanks,
Ralf

    Fix testsuite failure due to bugs in third-party aclocal macros.
    
    * tests/torture.at (Non-literal AC_CONFIG_SUBDIRS): Create a
    hand-written aclocal.m4 file, so the -Werror test doesn't fail
    over aclocal warnings about errors in third-party macro files.
    Simplify test accordingly, calling autoreconf throughout.
    Report by Bob Friesenhahn.

diff --git a/tests/torture.at b/tests/torture.at
index ff05928..97cb5c6 100644
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -1708,9 +1708,6 @@ AT_CLEANUP
 AT_SETUP([Non-literal AC_CONFIG_SUBDIRS])
 AT_KEYWORDS([autoreconf])
 
-# We use aclocal (via autoreconf).
-AT_CHECK([aclocal --version || exit 77], [], [ignore], [ignore])
-
 AT_DATA([install-sh], [])
 AT_DATA([configure.in],
 [[AC_INIT(GNU Outer, 1.0)
@@ -1724,6 +1721,11 @@ AC_CONFIG_SUBDIRS([$my_subdirs])
 AC_OUTPUT
 ]])
 
+# Hand-written aclocal.m4, so we don't invoke `aclocal -Werror' which
+# could barf over warnings in third-party macro files, or fail over
+# warnings with older aclocal which didn't yet understand -W*.
+AT_DATA([aclocal.m4])
+
 AS_MKDIR_P([foo])
 
 AT_DATA([foo/configure],
@@ -1738,9 +1740,7 @@ AT_CHECK([autoreconf -Werror -v], [1], [ignore], [stderr])
 AT_CHECK([grep 'AC_CONFIG_SUBDIRS:.*literals' stderr], [0], [ignore])
 AT_CHECK([autoreconf -v], [0], [ignore], [stderr])
 AT_CHECK([grep 'AC_CONFIG_SUBDIRS:.*literals' stderr], [0], [ignore])
-# We cannot assume aclocal won't warn (aclocal-1.9 does not understand -W*
-# options), so check autoconf only.
-AT_CHECK([autoconf --force -Wno-syntax], 0, [ignore], [stderr])
+AT_CHECK([autoreconf -v --force -Wno-syntax], 0, [ignore], [stderr])
 AT_CHECK([grep 'AC_CONFIG_SUBDIRS:.*literals' stderr], [1])
 
 AT_CHECK([./configure $configure_options], [0], [ignore])