[Bug-AUCTeX] Re: 11.83; AUCTeX toolbar

[Reiner Steib]

On Thu, Nov 09 2006, David Kastrup wrote:

> Ralf Angeli <address@hidden> writes:
>> * Nick Roberts (2006-11-09) writes:
>>
>>> Load AUCTeX is e.g by visiting a LaTeX file.  Turn tool-bar-mode on,
>>> then off and on again.  Then every buffer has AucTeX buttons in its
>>> toolbar and all local icons/buttons are overwritten.  

I.e. tool-bar-mode is off initially?

I can't reproduce this with the following commands (AUCTeX CVS):

emacs -xrm Emacs.toolBar:0 /tmp/foo.tex
M-x tool-bar-mode RET
M-x tool-bar-mode RET
M-x tool-bar-mode RET
C-c b *scratch* RET

>>> If I load AUCTeX by visiting a LaTeX file and then switch buffer
>>> before turning on tool-bar-mode then that buffer has AucTeX
>>> buttons and that of the LaTeX file doesn't!

Can't reproduce this neither.

>> I believe this has been fixed in CVS for months.  We really ought to
>> release 11.84 soon.
>
> Hm, looking through the code right now, I don't see how this fix would
> supposedly work.

Since there's no other recent change in `toolbar-x.el', I guess that
you refer to my change?

2006-09-13  Reiner Steib  <address@hidden>

        * toolbar-x.el (toolbarx-emacs-refresh): Don't modify global value
        of `tool-bar-map'.

--8<---------------cut here---------------start------------->8---
--- toolbar-x.el        25 May 2006 07:50:57 -0000      1.12
+++ toolbar-x.el        13 Sep 2006 20:15:00 -0000      1.13
@@ -1322,7 +1322,8 @@
                     toolbarx-internal-button-switches))
        (used-keys (list :used-symbols nil))
        (tool-bar-map-temp))
-    (let ((tool-bar-map (make-sparse-keymap)))
+    (let (tool-bar-map)
+      (set (make-local-variable 'tool-bar-map) (make-sparse-keymap))
       (toolbarx-emacs-refresh-process-button-or-insert-list switches used-keys)
       (setq tool-bar-map-temp (copy-sequence tool-bar-map)))
     (if global-flag
--8<---------------cut here---------------end--------------->8---

I don't know if this change fixed the problem of Nick, but it was a
fix for a different (but maybe related) problem, see
<http://thread.gmane.org/v98xknj3dd.fsf%40marauder.physik.uni-ulm.de>.

> Does it really do the right thing in existing buffers, regardless of
> whether they are current or not?

-v, please.  I'm not sure if my change is correct, but I don't quite
understand your question.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/