bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 07/10] glr2.cc: fix yyresolveValue


From: Akim Demaille
Subject: [PATCH 07/10] glr2.cc: fix yyresolveValue
Date: Sun, 6 Dec 2020 14:10:34 +0100

When "tests: glr2.cc: run the glr-regression tests" tests are run,
before this commit the following tests used to loop endlessly:

    709: Badly Collapsed GLR States: glr2.cc             FAILED 
(glr-regression.at:123)
    715: Improper merging of GLR delayed action sets: glr2.cc FAILED 
(glr-regression.at:397)
    718: Duplicate representation of merged trees: glr2.cc FAILED 
(glr-regression.at:495)
    751: Leaked semantic values when reporting ambiguity: glr2.cc FAILED 
(glr-regression.at:1632)

After this commit, no test loops and 709, 715, and 751 pass.  Only 718
still fails.

* data/skeletons/glr2.cc (yyresolveValue): Add missing incrementation
of the iteration variable.
---
 data/skeletons/glr2.cc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/skeletons/glr2.cc b/data/skeletons/glr2.cc
index a1194b61..6b60b38f 100644
--- a/data/skeletons/glr2.cc
+++ b/data/skeletons/glr2.cc
@@ -2439,6 +2439,7 @@ public:
           {
             yybest->mergeWith (*yyp);
             yypPrev->setNext(yyp->next());
+            yyp = yypPrev->next();
           }
         else
           {
-- 
2.29.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]