bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 00/10] glr2.cc: fixes


From: Akim Demaille
Subject: [PATCH 00/10] glr2.cc: fixes
Date: Sun, 6 Dec 2020 14:10:27 +0100

We currently have failures in glr2.cc.  Valentin provided some fixes
and improvements on his branch.  I had not installed them because the
example still fails after his fixes.  But yesterday I have
strenghtened the test suite for glr in such a way that today it is
very easy to run these tests on glr2.cc (see
https://lists.gnu.org/r/bison-patches/2020-12/msg00003.html).  That
gave me confidence on applying his commits, even though there are
still failures.

The new tests revealed two shortcomings.  Valentin, I would appreciate
if you could check at least the "glr2.cc: fix yyresolveValue" commit.

In addition to the failure of the example, the test suit currently has
four new failures:

    712: Improper handling of embedded actions and dollar(-N) in GLR parsers: 
glr2.cc expected failure (glr-regression.at:278)
    718: Duplicate representation of merged trees: glr2.cc expected failure 
(glr-regression.at:508)
    730: Incorrectly initialized location for empty right-hand side in GLR: 
glr2.cc expected failure (glr-regression.at:832)
    748: Incorrect lookahead during nondeterministic GLR: glr2.cc expected 
failure (glr-regression.at:1557)

I hope this will allow us to catch the remaining bug(s) more easily.
I'll install this in master once the CI validated it.  Meanwhile, it's
in ad/next.

Cheers!

Akim Demaille (7):
  glr.c: fix line numbers in logs
  glr2.cc: fix when the stack is not expandable
  glr2.cc: turn some pointers into references
  glr2.cc: fix yyresolveValue
  glr2.cc: add support for parse.assert
  glr2.cc: use the same format for traces as glr.c
  glr2.cc: run the glr-regression tests

Valentin Tolmer (3):
  glr2.cc: use 'const' for some constant local variables
  glr2.cc: fix memory corruption bug
  glr2.cc: misc cleanups

 TODO                    |  16 +++
 data/skeletons/glr.c    |   4 +-
 data/skeletons/glr2.cc  | 305 +++++++++++++++++++++-------------------
 tests/glr-regression.at |  49 ++++++-
 tests/local.at          |   3 +
 5 files changed, 224 insertions(+), 153 deletions(-)

-- 
2.29.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]