[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: push parser
From: |
Joel E. Denny |
Subject: |
Re: push parser |
Date: |
Tue, 12 Dec 2006 17:11:39 -0500 (EST) |
On Sun, 10 Dec 2006, Bob Rossi wrote:
> On Mon, Dec 04, 2006 at 06:15:46PM -0500, Joel E. Denny wrote:
> > 6. I read somewhere in this thread that yypushparse will never modify its
> > yynchar, yynlval, and yynlloc arguments. Shouldn't they be const then?
>
> Sure. Here's a patch, what do you think?
I would appreciate Paul Eggert's opinion on arguments with multiple
const's like this one:
const YYSTYPE * const yynlval
I'm pretty sure he'll at least want to see the first const moved:
YYSTYPE const * const ynlval
He may want to see the second const removed.
Sorry, I'm not sure why I listed yynchar. I was actually just thinking of
pointer arguments.
> Please give me direction on
> what else you would like me to modify in push.c. I'm not sure how many
> items on the original list you posted you still consider valid.
How about replacing yypstate_init with yypstate_new and yypstate_delete?
Sorry, I forgot about this during the previous renaming, but this will
probably be a nice self-contained patch anyway. Also, did you look into
using b4_c_function_def for these definitions? If you agree with these
ideas, you could proceed with them while we wait for Paul's response to
the above.
> I would definatly like to look at the members in the struct yypstate
> (with someone who understands them) to make sure they all belong there.
Yes, I think we should. However, I'm not intimately familiar with these,
so it takes me a while to figure them out. If you don't mind, we can
probably put this off a bit until we settle the other issues. We might
figure some out along the way anyway.
- Re: push parser, (continued)
- Re: push parser, Bob Rossi, 2006/12/15
- Re: push parser, Joel E. Denny, 2006/12/15
- Re: push parser, Bob Rossi, 2006/12/08
- Re: push parser, Joel E. Denny, 2006/12/08
- Re: push parser, Bob Rossi, 2006/12/08
- Re: push parser, Joel E. Denny, 2006/12/08
- Re: push parser, Bob Rossi, 2006/12/08
- Re: push parser, Joel E. Denny, 2006/12/08
- Re: push parser, Joel E. Denny, 2006/12/08
- Re: push parser, Bob Rossi, 2006/12/10
- Re: push parser,
Joel E. Denny <=
- Re: push parser, Paul Eggert, 2006/12/12
- Re: push parser, Joel E. Denny, 2006/12/12
- Re: push parser, Bob Rossi, 2006/12/13
- Re: push parser, Joel E. Denny, 2006/12/13
- Re: push parser, Bob Rossi, 2006/12/13
- Re: push parser, Joel E. Denny, 2006/12/13
- Re: push parser, Bob Rossi, 2006/12/14
- Re: push parser, Joel E. Denny, 2006/12/14
- Re: push parser, Bob Rossi, 2006/12/14
- Re: push parser, Joel E. Denny, 2006/12/14