[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] externals/bbdb 5610c9c: * bbdb-com.el, bbdb.el: Fix some warn

From: Roland Winkler
Subject: Re: [elpa] externals/bbdb 5610c9c: * bbdb-com.el, bbdb.el: Fix some warnings; plus cosmetic changes
Date: Tue, 12 Mar 2019 21:52:22 -0500

On Sun Mar 10 2019 Stefan Monnier wrote:
> @@ -2457,6 +2459,8 @@ If we are past `fill-column', wrap at the previous 
> comma."
>                ;; FIXME: This pops up *BBDB* before removing *Completions*
>                (bbdb-display-records records nil t)))
>          ;; `bbdb-complete-mail-hook' may access MAIL, ADDRESS, and RECORDS.
> +        ;; FIXME: Now that we use lexical-binding, these vars can't be 
> accessed
> +        ;; any more.  Maybe we should just change the doc!?
>          (run-hooks 'bbdb-complete-mail-hook))))

This code was updated to use lexical binding more than two years
ago; but nobody has complained so far that bbdb-complete-mail-hook
did not work anymore as expected.  Can we change the documentation
that it does not advertise anymore the inaccessible internal vars

reply via email to

[Prev in Thread] Current Thread [Next in Thread]