Re: [Axiom-developer] Testing build-improvements

[Gabriel Dos Reis]

Waldek Hebisch <address@hidden> writes:

| Gabriel Dos Reis wrote:
| > This patchlet works for me.  Could you test it?
| > 
| > *** document.in (revision 15247)
| > --- document.in (local)
| > *************** while test $# -gt 0 ; do
| > *** 129,136 ****
| >   
| >         --tangle)
| >            do_tangle=yes
| > !          if test -n $arg; then
| > !              chunk=$arg
| >            fi
| >            # --tangle may not be combined with any other
| >            # options.  FIXME:  Check that. 
| > --- 129,136 ----
| >   
| >         --tangle)
| >            do_tangle=yes
| > !          if test -n "$arg"; then
| > !              chunk=`echo -n $arg`
| >            fi
| >            # --tangle may not be combined with any other
| >            # options.  FIXME:  Check that. 
| > 
| 
| Works for me.  But I still do not understand this:
| 
|        chunk=`echo -n $arg`
| 
| thing (despite later messages).  Using bash I can just put
| 
|        chunk=$arg

Here is a patch to remove the yucky hack.

-- Gaby
*** ChangeLog.build-improvements        (revision 16912)
--- ChangeLog.build-improvements        (local)
***************
*** 1,5 ****
--- 1,9 ----
  2006-11-22  Gabriel Dos Reis  <address@hidden>
  
+       * document.in (--tangle): Remove yucky hack.
+ 
+ 2006-11-22  Gabriel Dos Reis  <address@hidden>
+ 
        * document.in (--tangle): Go through contorsions to support
        chunk names with embedded blank.
  
*** document.in (revision 16912)
--- document.in (local)
*************** while test $# -gt 0 ; do
*** 130,142 ****
        --tangle)
           do_tangle=yes
           if test -n "$arg"; then
!              # Ideally we would just assign $arg to chunk, possibly
!              # quoted.  However, some shells have their own
!              # ideas about what strings with embedded blank look
!              # like whe they are evaluated.  This disgusting hack
!              # is to ensure that chunk stores ONE string, with
!              # possibly embedded blank.
!              chunk=`echo -n $arg`
           fi
           # --tangle may not be combined with any other
           # options.  FIXME:  Check that. 
--- 130,136 ----
        --tangle)
           do_tangle=yes
           if test -n "$arg"; then
!              chunk=$arg
           fi
           # --tangle may not be combined with any other
           # options.  FIXME:  Check that.