avrdude-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[avrdude-dev] [patch] fmt_autodetect() and binary files


From: Theodore A. Roth
Subject: [avrdude-dev] [patch] fmt_autodetect() and binary files
Date: Fri, 13 Aug 2004 14:08:51 -0700 (PDT)

Hi,

I was just looking over the fmt_autodetect() function. When checking for
a binary file, it is possible (although unlikely) that ever byte in the
file has value < 128.

Wouldn't it make sense to just not even check for binary files? Just
check for recognizable format (ihex, srec, etc.) and if nothing is
found, just default to binary (and issue a warning).

I believe this is what bfd does and it seems to work well enough when we
use it with avarice.

Attached is a patch which should make all reads/writes via fileio.c be
binary and changes the above noted behaviour.

Can someone on a windows box try this to see if I borked anything? Does
it fix the mangled binary upload problem?

I noticed some *_imm stuff. I have no idea what that is, can any one
shed some light there?

---
Ted Roth
PGP Key ID: 0x18F846E9
Jabber ID: address@hidden

Attachment: avrdude-raw-bin.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]