Re: [Avr-libc-corelib] The SPI implementation

[Frédéric Nadeau]

Few comments:

I would rather have spi_init(mode,CLOCK speed, SPI_PHASE phase, SPI_CLOCK_POL
polarity);
Than having two seperate init block that do most of the same thing,

Missed SPI_CLK2 = 1, may not be available to all device though. But of
course it can't be used if you just pass the value to the register.

The rest I find great.

I wrote a SPI device at, maybe one would want to steel something from there.
http://code.google.com/p/avr-drv/source/browse/trunk/SPI/spiDef.h
http://code.google.com/p/avr-drv/source/browse/trunk/SPI/spi.h
http://code.google.com/p/avr-drv/source/browse/trunk/SPI/spi.c
but who as not writen one.

-- 
Frédéric Nadeau ing. jr