[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: use skip_ consistently.

From: Karl Berry
Subject: Re: [PATCH] tests: use skip_ consistently.
Date: Wed, 8 Jan 2020 15:03:55 -0700

    how about this instead? (feels a little like removing a double negative):
      test "$EMACS" = t && EMACS=emacs

Indeed, that looks a lot more natural, but as far as I can see, the
problem is Automake's pervasive use of set -e.

sh-4.2$ test "$FOO" = t && FOO=foo
sh-4.2$ echo $?

Thus the test failed when I tried it with $EMACS != t.

The need for circumlotions (double negatives or adding ||true or
if-then-else statements or whatever) is precisely why I don't much care
for set -e in my own code, although I fully realize it has its benefits
too, and certainly don't propose changing it now.

Anyway, if you prefer some other variant stylistically, fine by me.
--thanks, karl.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]