[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: use skip_ consistently.
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tests: use skip_ consistently. |
Date: |
Tue, 7 Jan 2020 21:23:19 -0800 |
On Tue, Jan 7, 2020 at 6:25 PM Karl Berry <address@hidden> wrote:
> I belatedly noticed that I should have used skip_ instead of exit 77
> in my new too-old-Emacs test. Plus found a wrong occurrence of just
> "skip" without the _ in uninstall-fail.sh. Look ok?
Good catches both.
I noticed this added line:
test "$EMACS" != t || EMACS=emacs
how about this instead? (feels a little like removing a double negative):
test "$EMACS" = t && EMACS=emacs
> (uninstall-fail has more failures in the case of a newer File::Path, due
> to changes in rmtree as used in deltree.pl, but that'll be another day.)
Thanks!