[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3] Shorter object file names under subdir-objects

From: Thomas Martitz
Subject: [PATCH v3] Shorter object file names under subdir-objects
Date: Wed, 24 May 2017 17:55:11 +0200


huge thanks for your review thus far.

I have reworked the patch, making most of your remarks moot. I have incorporated the remaining ones.

Change since v2:
- I changed the logic to first collect the targets via am_install_var, then scan for duplicated names (by the new handle_targets function), and then call handle_programs etc. - The whole truncation is now done after the blacklist check is succeeds (before the blacklist check was done last) - I changed the truncation logic itself to only truncate at directory boundaries (before it could truncate in the middle if a path component contained underscores), and also simplified it. - I refactored the test to be better readable and added a case for a clash between a program and a library.
- I changed to commit message and NEWS item according to your suggestions

Please review!

Best regards.

Attachment: 0001-Shorter-object-file-names-under-subdir-objects.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]