Re: bug#11093: [platform-testers] Automake 1.11.3b test release

[Stefano Lattarini]

Hi Bruno, thanks for the report.

On 04/21/2012 02:54 PM, Bruno Haible wrote:
> Hi Stefano,
> 
> In Automake 1.11.3b I reported these:
>>> FAIL: vala-vpath.test
>>> FAIL: vala-mix.test
>>> FAIL: vala-mix2.test
>>
>>> [SNIP]
>> ...
>>> Looking at git://git.gnome.org/vala it is clear that the option --profile
>>> was added on 2009-05-08, in version 0.7.3. The autoconf test reported
>>> "checking /arch/x86_64-linux/gnu/bin/valac is at least version 0.7... yes"
>>> which is correct. But it should have tested for at least version 0.7.3.
>>>
>> Thanks for the analysis.  I've added you as the main author of the patch to
>> fix this bug (attached).  Can you confirm that it works
> 
> Now I'm testing Automake 1.11.4 and 1.11.5. The vala-vpath.test is now
> SKIPped, as expected.
> 
> The tests vala-mix.test and vala-mix2.test and, in 1.11.5, vala-vapi.test
> all still failing, however.
> 
> FAIL: vala-mix.test
> FAIL: vala-mix2.test
> FAIL: vala-vapi.test
> 
> Excerpts from tests/test-suite.log:
> 
> 
> FAIL: vala-mix.test (exit: 1)
> =============================
> 
> vala-mix: running valac --version
> Vala 0.7.2
> vala-mix: dummy requirement 'cc', no check done
> vala-mix: running make --version -v | grep GNU
> GNU Make 3.81
> === Running test ./vala-mix.test
> ...
> checking for valac... /arch/x86_64-linux/gnu/bin/valac
> checking /arch/x86_64-linux/gnu/bin/valac is at least version 0.7.3... no
> configure: error: Vala 0.7.3 not found.
> + exit_status=1
> + set +e
> + cd /home/bruno/data/build/automake-1.11.5/tests
> + case $exit_status,$keep_testdirs in
> + test 0 '!=' 0
> + echo 'vala-mix: exit 1'
> vala-mix: exit 1
> + exit 1
> 
> FAIL: vala-mix2.test (exit: 1)
> ==============================
> 
> vala-mix2: running valac --version
> Vala 0.7.2
> vala-mix2: dummy requirement 'cc', no check done
> vala-mix2: dummy requirement 'c++', no check done
> vala-mix2: running make --version -v | grep GNU
> GNU Make 3.81
> === Running test ./vala-mix2.test
> ...
> checking for valac... /arch/x86_64-linux/gnu/bin/valac
> checking /arch/x86_64-linux/gnu/bin/valac is at least version 0.7.3... no
> configure: error: Vala 0.7.3 not found.
> + exit_status=1
> + set +e
> + cd /home/bruno/data/build/automake-1.11.5/tests
> + case $exit_status,$keep_testdirs in
> + test 0 '!=' 0
> + echo 'vala-mix2: exit 1'
> vala-mix2: exit 1
> + exit 1
> 
> FAIL: vala-vapi.test (exit: 1)
> ==============================
> 
> vala-vapi: running valac --version
> Vala 0.7.2
> vala-vapi: dummy requirement 'cc', no check done
> vala-vapi: running make --version -v | grep GNU
> GNU Make 3.81
> === Running test ./vala-vapi.test
> ...
> checking for valac... /arch/x86_64-linux/gnu/bin/valac
> checking /arch/x86_64-linux/gnu/bin/valac is at least version 0.7.3... no
> configure: error: Vala 0.7.3 not found.
> + exit_status=1
> + set +e
> + cd /home/bruno/data/build/automake-1.11.5/tests
> + case $exit_status,$keep_testdirs in
> + test 0 '!=' 0
> + echo 'vala-vapi: exit 1'
> vala-vapi: exit 1
> + exit 1
> 
> Whereas in the test that is skipped:
> 
> SKIP: vala-vpath.test (exit: 77)
> ================================
> 
> vala-vpath: running valac --version
> Vala 0.7.2
> vala-vpath: running make --version -v | grep GNU
> GNU Make 3.81
> === Running test ./vala-vpath.test
> ...
> checking for valac... /arch/x86_64-linux/gnu/bin/valac
> checking /arch/x86_64-linux/gnu/bin/valac is at least version 0.7.3... no
> configure: error: Vala 0.7.3 not found.
> + Exit 77
> + set +e
> + exit 77
> + exit 77
> + exit_status=77
> + set +e
> + cd /home/bruno/data/build/automake-1.11.5/tests
> + case $exit_status,$keep_testdirs in
> + test 0 '!=' 0
> + echo 'vala-vpath: exit 77'
> vala-vpath: exit 77
> + exit 77
> 
> This patch fixes the failures.
> 
> --- tests/vala-mix2.test.bak  2012-04-13 16:46:01.000000000 +0200
> +++ tests/vala-mix2.test      2012-04-21 14:50:53.000000000 +0200
> @@ -73,7 +73,7 @@
>  $AUTOMAKE -a
>  $AUTOCONF
>  
> -./configure
> +./configure || Exit 77
>  
>  $MAKE all
>  ls -l # For debugging.
> --- tests/vala-mix.test.bak   2012-04-13 16:46:01.000000000 +0200
> +++ tests/vala-mix.test       2012-04-21 14:50:49.000000000 +0200
> @@ -87,7 +87,7 @@
>  $AUTOMAKE -a
>  $AUTOCONF
>  
> -./configure
> +./configure || Exit 77
>  
>  $MAKE all
>  ls -l # For debugging.
> --- tests/vala-vapi.test.bak  2012-04-13 16:46:01.000000000 +0200
> +++ tests/vala-vapi.test      2012-04-21 14:50:56.000000000 +0200
> @@ -66,7 +66,7 @@
>  $AUTOMAKE -a
>  $AUTOCONF
>  
> -./configure --enable-dependency-tracking
> +./configure --enable-dependency-tracking || Exit 77
>  
>  $MAKE
>  ls -l        # For debugging.
> 

I think that the best fix would be to improve AM_PROG_VALAC to exit
with status '77' instead of '1' if the vala compiler found is too old;
so, what about the attached patch?  Most importantly, would it fix
the failures you are seeing?

Thanks,
  Stefano

0001-vala-configure-exit-with-status-77-not-1-if-valac-ve.patch
Description: Text Data