automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#11093: [platform-testers] Automake 1.11.3b test release


From: Bruno Haible
Subject: Re: bug#11093: [platform-testers] Automake 1.11.3b test release
Date: Sat, 21 Apr 2012 17:22:03 +0200
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Stefano Lattarini wrote:
> I think that the best fix would be to improve AM_PROG_VALAC to exit
> with status '77' instead of '1' if the vala compiler found is too old;
> so, what about the attached patch?  Most importantly, would it fix
> the failures you are seeing?

The patch you sent does not apply to an 1.11.5 tree. In particular it
contains references to a t/ directory.

Aaaahhh! tests/ got renamed to t/ ?!? Like s/ and m/ in Emacs?
This patch [1] is really backwards in time. It makes me feel like in the
1980ies where people were trying to make file names as short as they
could. How long will this workaround help? 1 or 2 years, and you will
reach the Woe32 limit again. So you've crippled the appealingness of
Automake to new contributors for the ability to run the Automake
test suite on one(!) particular mingw platform just for 1-2 years.
A bad compromise.
[1] http://lists.gnu.org/archive/html/automake-patches/2012-04/msg00047.html

Anyway, your patch applies to the 1.11d tree, but then I can't configure
and make:

$ patch -p1 < ~/0001-vala-configure-exit-with-status-77-not-1-if-valac-ve.patch 
patching file NEWS
patching file m4/vala.m4
patching file t/vala-headers.sh
patching file t/vala-libs.sh
patching file t/vala-vpath.sh
patching file t/vala2.sh
patching file t/vala3.sh
patching file t/vala4.sh
patching file t/vala5.sh
$ ./configure 
...
configure: creating ./config.status
config.status: creating Makefile
config.status: creating t/wrap/aclocal-1.11d
config.status: creating t/wrap/automake-1.11d

WARNING: You are about to use a beta version of automake.
WARNING: It might easily suffer from new bugs or regressions.
WARNING: You are strongly advised not to use it in production code.

Please report bugs, problems and feedback to <address@hidden>.
$ make
  GEN      t/testsuite-part.am
 cd . && perllibdir="/home/bruno/data/build/automake-1.11d/lib:./lib" 
"/home/bruno/data/build/automake-1.11d/automake" --libdir=lib --gnu 
--ignore-deps Makefile
/bin/sh: Zeile 11: /home/bruno/data/build/automake-1.11d/automake: Datei oder 
Verzeichnis nicht gefunden
make: *** [Makefile.in] Error 127

Indeed there is no file 'automake' in the top level directory of the
automake-1.11d tarball, and running './configure' did not create it.

How to reproduce:
1. Unpack automake-1.11d.tar.gz
2. patch -p1 < 
.../0001-vala-configure-exit-with-status-77-not-1-if-valac-ve.patch
3. ./configure
4. make

Can you please point me to a temporary tarball instead, that I could test?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]