automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cle


From: Ralf Wildenhues
Subject: Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly
Date: Sun, 20 Feb 2011 18:42:06 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Sun, Feb 20, 2011 at 12:39:36PM CET:
> On Saturday 19 February 2011, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Wed, Feb 16, 2011 at 09:26:17PM CET:
> > > -    find "$$@" -type d '!' -perm -200 -exec chmod u+w {} ';'; \
> > > +    find "$$@" -type d ! -perm -700 -exec chmod u+rwx {} ';'; \

> > please don't remove the quoting from the ! here.  It exists to
> > facilitate copy and pasting commands from make output to the command
> > line,
> >
> Why would the quoting being useful for that?  As long as '!' is
> whitespace-separated from the following word, it's regarded by
> the shell as a literal character, even when the shell has history
> substutution enabled, no?  Or am I missing something?

I guess you're right.  I sometimes err on the safe side when doing
defensive coding, rather than looking up the exact rules again.

> > so even if it's not needed inside scripts, it is good defensive
> > coding to have it there too.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]