Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

[Ralf Wildenhues]

Hi Stefano,

sorry for the silence, I've been traveling.  My plan is to do slowly but
steady catchup over the next week(end)s ...

* Stefano Lattarini wrote on Wed, Feb 16, 2011 at 09:26:17PM CET:
> * tests/defs: Ensure that all the subdirectories of a temporary
> test directory have the 'read', 'write' and 'execute' bits set,
> before trying to remove it with `rm -rf'.
> * tests/Makefile.am (clean-local-check): Likewise.

OK, but ...

> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -839,6 +839,6 @@ clean-local-check:
>        if test "$$#,$$1" = "1,*.dir"; then \
>          : there is no test directory to clean; \
>        else \
> -        find "$$@" -type d '!' -perm -200 -exec chmod u+w {} ';'; \
> +        find "$$@" -type d ! -perm -700 -exec chmod u+rwx {} ';'; \
>          rm -rf "$$@"; \
>        fi;

please don't remove the quoting from the ! here.  It exists to
facilitate copy and pasting commands from make output to the command
line, so even if it's not needed inside scripts, it is good defensive
coding to have it there too.

Also, it would seem that this issue is present in lib/am/distdir.am
as well.  Care to address that (in another patch, if you like)?

Thanks,
Ralf