[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] Vala: Use $(srcdir) in rebuild rules
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 3/3] Vala: Use $(srcdir) in rebuild rules |
Date: |
Sat, 9 May 2009 19:51:38 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi Jürg,
* Jürg Billeter wrote on Sat, May 09, 2009 at 03:09:03PM CEST:
> valac is always run in srcdir as the generated files are distributed.
> So srcdir needs to be taken into account in the rebuild rules to not
> wrongly trigger a rebuild in the wrong directory.
Can you add (or amend current) test cases for patch 2 and 3, or indicate
how I could write them otherwise? Generally, we should try to test each
bug that we fix, to ensure we consistently get better. Also, it would
give me more confidence when improving things later.
Thanks!
Ralf