Re: [PATCH 3/3] Vala: Use $(srcdir) in rebuild rules

[Jürg Billeter]

Hi Ralf,

On Sat, 2009-05-09 at 19:51 +0200, Ralf Wildenhues wrote:
> Hi Jürg,
> 
> * Jürg Billeter wrote on Sat, May 09, 2009 at 03:09:03PM CEST:
> > valac is always run in srcdir as the generated files are distributed.
> > So srcdir needs to be taken into account in the rebuild rules to not
> > wrongly trigger a rebuild in the wrong directory.
> 
> Can you add (or amend current) test cases for patch 2 and 3, or indicate
> how I could write them otherwise?  Generally, we should try to test each
> bug that we fix, to ensure we consistently get better.  Also, it would
> give me more confidence when improving things later.

I've just resent the patch set to the mailing list. I've amended
vala2.test for patch 2 and 3 and made sure that the new test fails
without the patches and succeeds with the patches.

Regards,
Jürg