[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
autoconf 2.57 and DJGPP: IFS=: and constructing paths
From: |
Richard Dawe |
Subject: |
autoconf 2.57 and DJGPP: IFS=: and constructing paths |
Date: |
Sat, 11 Jan 2003 11:36:31 +0000 |
Hello.
Some code in autoconf 2.57 constructs paths and then outputs them using echo.
Unfortunately this is done with IFS=: and there is not enough quoting to
ensure that DOS absolute paths are not split on the colon. Below is a
ChangeLog and patch for a fix.
I have seen the "# Absolute (can't be DOS-style, as IFS=:)" comment. This
problem is nothing to do with that, since I hit problems with IFS splitting
the path when the directories were relative.
I had a quick look at CVS and it seems that there is another place where IFS=:
is used now. It looks like that needs fixing too.
Thanks, regards,
--
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]
2003-01-11 Richard Dawe <address@hidden>
* lib/autoconf/status.m4: Quote constructed paths when IFS=:,
so that DOS absolute paths are not split on the colon.
--- /dev/c/develop/ports/orig/autoconf-2.57/lib/autoconf/status.m4
2002-11-12
10:54:46.000000000 +0000
+++ /dev/c/develop/ports/gnu.dev/autoconf-2.57/lib/autoconf/status.m4
2003-01-04 18:15:58.000000000 +0000
@@ -523,14 +523,14 @@ for ac_file in : $CONFIG_HEADERS; do tes
[[\\/$]]*)
# Absolute (can't be DOS-style, as IFS=:)
test -f "$f" || AC_MSG_ERROR([cannot find input file: $f])
- echo $f;;
+ echo "$f";;
*) # Relative
if test -f "$f"; then
# Build tree
- echo $f
+ echo "$f"
elif test -f "$srcdir/$f"; then
# Source tree
- echo $srcdir/$f
+ echo "$srcdir/$f"
else
# /dev/null tree
AC_MSG_ERROR([cannot find input file: $f])
@@ -979,14 +976,14 @@ AC_PROVIDE_IFELSE([AC_PROG_INSTALL],
[[\\/$]]*)
# Absolute (can't be DOS-style, as IFS=:)
test -f "$f" || AC_MSG_ERROR([cannot find input file: $f])
- echo $f;;
+ echo "$f";;
*) # Relative
if test -f "$f"; then
# Build tree
- echo $f
+ echo "$f"
elif test -f "$srcdir/$f"; then
# Source tree
- echo $srcdir/$f
+ echo "$srcdir/$f"
else
# /dev/null tree
AC_MSG_ERROR([cannot find input file: $f])
- autoconf 2.57 and DJGPP: IFS=: and constructing paths,
Richard Dawe <=