[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] improve autotest syntax checks
From: |
Ralf Wildenhues |
Subject: |
Re: [RFC] improve autotest syntax checks |
Date: |
Fri, 7 Mar 2008 19:30:20 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
Hello Eric,
This patch series is OK, but please look at the nits below.
Thanks for your good work on this!
* Eric Blake wrote on Wed, Mar 05, 2008 at 10:08:11PM CET:
> Allow LIFO autom4te cleanup, regardless of m4_wrap being LIFO or FIFO.
> * doc/autoconf.texi (Diagnostic Macros) <m4_fatal>: Document
> argument.
> (Redefined M4 Macros) <m4_wrap>: Improve documentation.
> (Diversion support) <m4_init>: Add optional parameter.
> (Programming in M4sh) <AS_INIT>: Likewise.
> * lib/m4sugar/m4sugar.m4 (m4_init): Add cleanup parameter.
> * lib/m4sugar/m4sh.m4 (AS_INIT): Likewise.
m4_init([cleanup]) and AS_INIT([cleanup]) must belong to the least
intuitive interfaces that I've seen so far. Why something named init
receives a cleanup argument rather than the name of or the thing that
it initializes, will not be understandable to users, and any apparent
analogy to AC_INIT or AT_INIT is just borked.
I don't have a good idea how to improve this, but I must confess that I
don't like it much. Maybe have a macro m4_init_wrap for this or so?
Also, this patch series (and maybe the interface change) deserves a NEWS
entry.
> diff --git a/tests/autotest.at b/tests/autotest.at
> index 885ecca..5d0cec8 100644
> --- a/tests/autotest.at
> +++ b/tests/autotest.at
[...]
> +AT_CHECK_AT_SYNTAX([Multiple AT@&address@hidden,
> +[[AT_INIT([suite, take one])
You need to double-quote comma inside AT_INIT's argument.
> +AT_INIT([repeat])
> +]], [AT@&address@hidden: invoked multiple times])
Cheers,
Ralf