[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Remove the rest of the comment from _AC_CACHE_DUMP
From: |
Paul Eggert |
Subject: |
Re: Remove the rest of the comment from _AC_CACHE_DUMP |
Date: |
Sat, 08 Apr 2006 23:30:48 -0700 |
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) |
Ralf Wildenhues <address@hidden> writes:
> | - sed '/^$/d' confdefs.h
> | + sed "/^$/d" confdefs.h
This is a risky change, since it relies on "$/" being treated like
'$/'. I don't think POSIX requires that; I think POSIX allows a sh
implementation, as an extension, to expand "$/" to something else.
I installed this to fix the potential problem, and to use a better
way to put an apostrophe in a single-quoted string.
2006-04-08 Paul Eggert <address@hidden>
* lib/autoconf/general.m4 (_AC_INIT_PREPARE): Use '\'' for an
apostrophe within a single-quoted string, as this is the usual
tradition and is easier to read than '"'"'. Don't rely on the
shell treating "$/" like '$/'. Use a more-consistent indenting
style for the trap.
--- lib/autoconf/general.m4 8 Apr 2006 21:46:04 -0000 1.903
+++ lib/autoconf/general.m4 9 Apr 2006 06:29:28 -0000 1.905
@@ -1199,8 +1199,9 @@ AS_UNSET(ac_configure_args1)
# When interrupted or exit'd, cleanup temporary files, and complete
# config.log. We remove comments because anyway the quotes in there
# would cause problems or look ugly.
-# WARNING: Do not use single quotes inside single quotes.
-trap 'exit_status=$?
+# WARNING: Use '\'' to represent an apostrophe within the trap.
+trap '
+ exit_status=$?
# Save into config.log some information that might help in debugging.
{
echo
@@ -1210,7 +1211,7 @@ trap 'exit_status=$?
m4_bpatsubsts(m4_defn([_AC_CACHE_DUMP]),
[^ *\(#.*\)?
], [],
- ['], ['"'"'])
+ ['], ['\\''])
echo
AS_BOX([Output variables.])
@@ -1218,7 +1219,7 @@ trap 'exit_status=$?
for ac_var in $ac_subst_vars
do
eval ac_val=\$$ac_var
- echo "$ac_var='"'"'$ac_val'"'"'"
+ echo "$ac_var='\''$ac_val'\''"
done | sort
echo
@@ -1228,15 +1229,14 @@ trap 'exit_status=$?
for ac_var in $ac_subst_files
do
eval ac_val=\$$ac_var
- echo "$ac_var='"'"'$ac_val'"'"'"
+ echo "$ac_var='\''$ac_val'\''"
done | sort
echo
fi
if test -s confdefs.h; then
AS_BOX([confdefs.h.])
- echo
- sed "/^$/d" confdefs.h | sort
+ sort -u confdefs.h
echo
fi
test "$ac_signal" != 0 &&
@@ -1244,9 +1244,9 @@ trap 'exit_status=$?
echo "$as_me: exit $exit_status"
} >&AS_MESSAGE_LOG_FD
rm -f core *.core core.conftest.* &&
- rm -f -r conftest* confdefs* conf$[$]* $ac_clean_files &&
+ rm -f -r conftest* confdefs* conf$[$]* $ac_clean_files &&
exit $exit_status
- ' 0
+' 0
for ac_signal in 1 2 13 15; do
trap 'ac_signal='$ac_signal'; AS_EXIT([1])' $ac_signal
done
- Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/06
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/06
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Ralf Wildenhues, 2006/04/06
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/07
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/07
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Ralf Wildenhues, 2006/04/08
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/08
- Re: Remove the rest of the comment from _AC_CACHE_DUMP,
Paul Eggert <=
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Noah Misch, 2006/04/09
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Paul Eggert, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Ralf Wildenhues, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Paul Eggert, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Ralf Wildenhues, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Stepan Kasal, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Ralf Wildenhues, 2006/04/10
- Re: Remove the rest of the comment from _AC_CACHE_DUMP, Paul Eggert, 2006/04/10