[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changing AT_CHECK

From: Pavel Roskin
Subject: Re: Changing AT_CHECK
Date: Mon, 11 Dec 2000 22:19:12 -0500 (EST)

Hello, Akim!

> For your information, here is the resulting AT_CHECK.  I also think
> `0' is a better default for the expected exit status, as opposed to
> `ignore'.

Sorry that I couldn't answer earlier.

The patch looks good. I have never used "-n". It didn't work fully anyway
since stdout and strerr were not checked. I hope you are aware that
"testsuite --help" is still suggesting "-n".

> dnl Check stderr.
> m4_case([$4],
>        ignore, [cat stderr >&5],
>        experr, [AT_CLEANUP_FILE([experr])dnl

This is similar (maybe identical) to the old behaviour, but I don't think
it's correct. If stderr is to be ignored then it should not be printed.

In most cases stderr should not be ignored, but if it is then it means
that something may be printed on stderr and it's Ok. In this case,
repeating possible error messages in the output of the testsuite would be
rather confusing than helpful.

Everything else is Ok.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]