[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XBoard-devel] WinBoard sources missing
From: |
Arun Persaud |
Subject: |
Re: [XBoard-devel] WinBoard sources missing |
Date: |
Fri, 06 Nov 2009 09:11:16 -0800 |
User-agent: |
Thunderbird 2.0.0.23 (X11/20090817) |
Hi
HGM wrote:
> OK, I am in favor of an immediate 4.4.2 release, then.
> Problem is that I submitted the patches in the wrong order,
> as I discovered the bug I introduced in the FEN pasting
> only when doing the refctoring of e.p. and castling rights.
> I would prefer that refactoring to go into a beta version,
> and not dump it completely untested in a "stable release".
>
> Is there any easy way for you to invert the order of patches,
> when they are to the same file? Solving the bug is reasonably
> easy and low-risk; it is just a matter of equiping EditPositionDone()
> with a Boolean argument fakeRights, and putting an
> if(fakeRights) { ... } around the castling-rights code.
> It is called quite a few times, though, and all except the last call
> should be with argument value TRUE.
should be relatively easy... as an alternative I could also just add the
winboard sources and put a tar-ball with the winboard source up for
download without any other modifications and we just don't change
version numbers yet. Or we get just test your refactoring patch to
include it too in 4.4.2 ;)
What does everyone else think about those three options?
Anyway, it will have to wait until tomorrow or Sunday until I will have
time to do it.
ARUN
- Re: [XBoard-devel] Plans for 4.4.2, (continued)
- [XBoard-devel] WinBoard sources missing, h.g. muller, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, Tim Mann, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, Arun Persaud, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, Eric Mullins, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, h.g. muller, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, Arun Persaud, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, h.g. muller, 2009/11/06
- Re: [XBoard-devel] WinBoard sources missing,
Arun Persaud <=
- [XBoard-devel] EditGame clears resultDetails, h.g. muller, 2009/11/06
- Re: [XBoard-devel] EditGame clears resultDetails, Tim Mann, 2009/11/06
- Re: [XBoard-devel] WinBoard sources missing, h.g. muller, 2009/11/06
- Message not available
- Re: [XBoard-devel] WinBoard sources missing, Arun Persaud, 2009/11/05
- Re: [XBoard-devel] WinBoard sources missing, Arun Persaud, 2009/11/05
- [XBoard-devel] Requested feature: variations, h.g. muller, 2009/11/05
- Re: [XBoard-devel] Requested feature: variations, Arun Persaud, 2009/11/05
- Re: [XBoard-devel] Plans for 4.4.2, h.g. muller, 2009/11/03