[Swftools-common] configure has a false negative detection for lame detection

[Larry Hajali]

Hi all,

First off, I'm no part of the mailing list, so any emails in response to this, hopefully, will include my email address as well.

Anyways, I compiled swftools both from the configure script and from the setup.py script.  I noticed that when configure is running it fails to detect my lame package.  Looking at the configure script it looks as if configure can properly find the lame library and appropriate header file but there is a false negative when lame is installed.

Specifically, at line 1905 in the configure script when "--enable-lame" is true then the variable "DISABLE_LAME=true".  This, however, is wrong when lame is installed on the system.  If "DISABLE_LAME=false", then lame detection occurs and is properly compiled into swftools.  The opposite is also true when "--enable-lame" is given to configure but is not installed.

I looked at the code, and I was only able to make a patch to the configure script rather then the configure.in or *.m4 files.  Here is the patch.

diff -Naur swftools-0.9.0.orig/configure swftools-0.9.0/configure

--- swftools-0.9.0.orig/configure    2009-04-17 15:40:10.000000000 +0000
+++ swftools-0.9.0/configure    2009-05-17 00:06:34.000000000 +0000
@@ -1902,7 +1902,7 @@
 
 # Check whether --enable-lame was given.

 if test "${enable_lame+set}" = set; then
-  enableval=$enable_lame; DISABLE_LAME=true
+  enableval=$enable_lame; DISABLE_LAME=false
 fi
 
 
Thanks,
Larry