[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Swftools-common] external libraries carried in source

From: Matthias Kramm
Subject: Re: [Swftools-common] external libraries carried in source
Date: Fri, 11 Jul 2008 10:34:06 +0200
User-agent: Mutt/1.5.6i

On Fri, Jul 11, 2008 at 01:21:51AM +0200, Patrice Dumas <address@hidden> wrote:
> I don't think it makes much sense to check if there is a lib/art in the
> source tree, since the configure switch --with-external-libart takes
> precedence. I could add that check, if you really want to, but I don't 
> think it is relevant as long as there is a configure switch and no
> autodetection.

You're right- for lame, that check is present because lame is 
not in the .tar.gz, only in CVS. But libart will probably always
be part of the source distribution.

> I attach a patch which does the external libart detection, but only if
> --with-external-libart is selected. It is non-functional, for the reason
> I presented in another mail, but even though it is non functional, I
> think that it could make sense to incorporate it, be it only to be able
> to test an external libart. The ./configure --help message is 
>   use external libart library (at your own risk)
> it could even be clearer that it doesn't work.

Patch looks good- I'll apply it, with a few minor changes



reply via email to

[Prev in Thread] Current Thread [Next in Thread]