Re: [STUMP] [RESEND] [PATCHES]

[Shawn]

Michael Raskin <address@hidden> writes:

> I never got any reaction beyond "Oh, they got forgotten" when I
> reminded about these patches, so I send them once more...

I'm sorry.

> Subject: [PATCH] Adding redisplay functionality from ratpoison 
> (refresh+occupy entire frame) and refresh command (just resize a step down 
> and a step up to make application repaint its window). Binding from 
> ratpoison: l is redisplay.

We talked about the redisplay/refresh patch on irc. The problem is
that the maximize function depends on the current size for windows
with resize increment hints. So changing the window size and calling
maximize causes emacs windows (this is the window I noticed the
problem on) to be set to incorrect sizes.

I like the idea. So if you can fix that, I have no problem adding it
to stumpwm.

> Subject: [PATCH] Added a command to compact window numbers
> Subject: [PATCH] Added logging of OSD messages

Applied! Thank you!

> Subject: [PATCH] Added possibility to add arbitrary prefix to commands in 
> stumpish (the suggested use is adding eval to get a StumpWM Common Lisp REPL)

There has to be a better way to do this. How about a dedicated REPL
loop that you can use with stumpish --repl?

> Subject: [PATCH] Added possiility not to use ncurses for colouring.

> +if [ -n "$NO_NCURSES" ]; then
> +    tput () { : ; };
> +fi;
> +

Is $NO_NCURSES a standard environment variable? When I run stumpish
from emacs' shell I don't get any color escape codes. So I'm having
trouble seeing where this is useful.

> Subject: [PATCH] Added commands to save/load placement information using 
> window properties. Good when restarting stumpwm..

This is a great idea, but not a very good implementation of it. It
requires the user to manually add group & frame properties to windows
when it should be automatic.

Also, the group is already stored as a _NET_* property (is it
_NET_DESKTOP or something?) so you don't need to set that.

I hope that helps!

-Shawn