speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/3] added autotest support


From: Andrei Kholodnyi
Subject: [PATCH 1/3] added autotest support
Date: Mon, 27 Sep 2010 12:34:10 +0200

Hi William,

> I posted the following patch a few weeks ago:
> http://lists.freebsoft.org/pipermail/speechd/2010q3/002818.html

without the rest /autotest binding etc./ your patch IMO makes not much sense.
If you would like I can drop my patches and you'll provide your
version with autotest support
Or we can put in the patch's comments that this line:
+check_PROGRAMS = long_message clibrary clibrary2 run_test connection_recovery
came form your patch. Whatever you decide is fine with me.

> Based on the same reason in the post above, I don't feel comfortable
> putting this series in the tree.

Yes, that's true. I also feel uncomfortable with this series,
since I still do not understand how I could make installcheck in
cross-compile environment.
And this I try to clarify by posting to autools mail list.

However I believe autotest support which this series introduces
will be a good first step to allow running all tests automatically.

> If we do decide to put this in the tree, I request that my patch be
> pushed first, so that I will receive credit for it in our commit logs,
> then this series can be rebased against master.

as explained above, I'd rather prefer to drop my series then and wait
for your version.

> For the record, I'm not accusing anyone of anything, I'm just
> concerned about my previous patch and the reason it was rejected,
> considering that it is ?being brought back in another patch.

I hope I have explained the reason.

Thanks,
Andrei.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]