[PATCH] remove duplicate implementations of a function

[Christopher Brannon]

Trevor Saunders <trev.saunders at gmail.com> writes:

> espeak, ibmtts, and ivona all had there own <module_name>_play_file()
> function replace them with a single implementation in module_utils.c

The idea is good, but the patch doesn't work.

1. module_utils.c doesn't include config.h.
HAVE_SNDFILE is never defined, so the new function is a no-op.
2. The DBG calls mention espeak.  You can strip the prefix entirely,
because each module logs to a file named MODULE_NAME.log.  You could
also use a generic prefix, I suppose.
3. The following call only works for espeak:
                spd_audio_set_volume(module_audio_id, EspeakSoundIconVolume);
Do something more generic, please.

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100902/b902756c/attachment.pgp>