speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] bug fix for a buffer overflow in ivona_client.c


From: Christopher Brannon
Subject: [PATCH] bug fix for a buffer overflow in ivona_client.c
Date: Thu, 02 Sep 2010 06:11:51 -0500

Trevor Saunders <trev.saunders at gmail.com> writes:

> +     int len = strlen(IvonaSoundIconPath) + strlen(name) + 2;
> +     char *buf = g_malloc(len);
> +sprintf(buf, "%s/%s", IvonaSoundIconPath, name);

I'd suggest replacing these three lines with:
char *buf = g_strdup_printf("%s/%s", IvonaSoundIconPath, name);

-- Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100902/eaa008ca/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]