Re: [Simulavr-devel] Timer Test

[Keith Gudger]

Ted:

The timer.c changes I'm talking about were in the AVR code, not the
simulavr code.  I couldn't download your test program because I'm dialed
in today.  So the changes I made just removed the timer interrupt routines
for the stuff not in the at43usb320.

BTW, I think I may have changed one line in spi.c since the file I sent
you.  Around line 190, there was something like:
        spi->spsr &= ~mask_SPIF;
        spi->spsr = 0;

The second line was a mistake, and I took it out. 

Keith

 On Wed, 12 Nov 2003, Theodore A. Roth wrote:

> 
> 
> On Wed, 12 Nov 2003, Keith Gudger wrote:
> 
> > >
> > > I ended up hacking the test_c/timer.c file that Hermann previously
> > > submitted to compile for the at43usb320 (my changes are in cvs now). Then 
> > > to
> > > I ran the program in gdb using the attached gdb.in file. Basically, it
> > > breaks on all interrupts. Once I hit and intr, I disabled that break and
> > > continued. I saw intr's fire for OVERFLOW0, OVERFLOW1, COMP1A and COMP1B.
> > >
> > > Keith, can you try running the test_c/timer.c program and let me know if 
> > > it
> > > works for you? If it's ok, I think I'll go ahead and commit your timers
> > > patch.
> > >
> >
> > I hacked timer.c and ran it.  It worked fine - the patch looks great still
> > to me.  Commit it (or me?).
> 
> What changes did you have to make to timer.c?
> 
> I'll commit it tonight. Then on to the SPI patch...
> 
> >
> > > Am I correct I in thinking that the patch you submitted is a
> > > combined effort of you and Hermann? I just want to give proper
> > > credit for it in the ChangeLog file.
> > >
> >
> > Hermann wrote the code, which I "borrowed" from his patch.  I just took
> > out the bitpos stuff so if would work with the current CVS files.
> 
> Ok. I'll give Hermann main credit then and note that you did revising to
> work it into the existing code base.
> 
> Ted Roth
> 
> 
>