[Rdiff-backup-bugs] [bug #15839] fsync fails on a read-only file

[anonymous]

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=15839>

                 Summary: fsync fails on a read-only file
                 Project: rdiff-backup
            Submitted by: None
            Submitted on: Tue 02/21/06 at 14:30
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open

    _______________________________________________________

Details:

I installed rdiff-backup-1.0.4 under AIX 5.3. When running a simple local
test backup, I got the following message : 

address@hidden build]$ rdiff-backup SPECS /tmp/backup-fthomas/
Traceback (most recent call last):
  File "/usr/bin/rdiff-backup", line 23, in ?
    rdiff_backup.Main.Main(sys.argv[1:])
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/Main.py", line
285, in Main
    take_action(rps)
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/Main.py", line
255, in take_action
    elif action == "backup": Backup(rps[0], rps[1])
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/Main.py", line
309, in Backup
    rpout.conn.Main.backup_touch_curmirror_local(rpin, rpout)
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/Main.py", line
467, in backup_touch_curmirror_local
    mirrorrp.fsync_with_dir()
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/rpath.py",
line 1080, in fsync_with_dir
    self.fsync(fp)
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/rpath.py",
line 1068, in fsync
    if not fp: self.conn.rpath.RPath.fsync_local(self)
  File "/opt/freeware/lib/python2.3/site-packages/rdiff_backup/rpath.py",
line 1075, in fsync_local
    os.fsync(fd)
OSError: [Errno 9] Bad file number
Exception exceptions.TypeError: "'NoneType' object is not callable" in <bound
method GzipFile.__del__ of <gzip open file
'/tmp/backup-fthomas/rdiff-backup-data/error_log.2006-02-21T15:27:37+01:00.data.gz',
mode 'wb' at 0x202940e8 0x20293698>> ignored

I commented out the os.fsync(fd) line in rpath.py and the problem went away.
I believe this is related to the fact that the file is open in read-only and
that it's probably forbidden to fsync a file that's open in read-only.

excerpt from rpath.py : 

        def fsync_local(self):
                """fsync current file, run locally"""
                assert self.conn is Globals.local_connection
                fd = os.open(self.path, os.O_RDONLY)
                #os.fsync(fd)
                os.close(fd)








    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=15839>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/