[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Use pre-defined macr

From: Wei Huang
Subject: Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Use pre-defined macro for cpu_num in code
Date: Thu, 5 Nov 2015 10:55:09 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 11/05/2015 09:31 AM, Peter Maydell wrote:
> On 5 November 2015 at 15:12, Wei Huang <address@hidden> wrote:
>> Given that there is a macro, NUM_CPU(s), defined for CPU number in
>> arm_gic.c, it is better to use it instead of using s->num_cpu in
>> this file. Code is more consistent after this change.
> Hi. I think that actually since the NUM_CPU is just a relic from

Looks like the relic was from c988bfadc9cab. I prefer macro for this
case; but will fix based on your comments.


> when it used to possibly defined as something other than s->num_cpu,
> we should go in the opposite direction, and remove the macro entirely
> in favour of just using s->num_cpu directly.
> (PS: you forgot to cc qemu-devel.)
> thanks
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]