[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Use pre-defined macr
Re: [Qemu-trivial] [PATCH Trivial] hw/intc/arm_gic: Use pre-defined macro for cpu_num in code
Thu, 5 Nov 2015 15:31:30 +0000
On 5 November 2015 at 15:12, Wei Huang <address@hidden> wrote:
> Given that there is a macro, NUM_CPU(s), defined for CPU number in
> arm_gic.c, it is better to use it instead of using s->num_cpu in
> this file. Code is more consistent after this change.
Hi. I think that actually since the NUM_CPU is just a relic from
when it used to possibly defined as something other than s->num_cpu,
we should go in the opposite direction, and remove the macro entirely
in favour of just using s->num_cpu directly.
(PS: you forgot to cc qemu-devel.)