[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15 |
Date: |
Thu, 15 Jan 2015 13:08:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 15/01/2015 12:55, Peter Maydell wrote:
> > With the introduction of pbonzini's "misc" patches tree I'm not
> > sure current trivial-patches is worth to keep. Paolo does much
> > better job in this area than me.
>
> I'll leave that up to the two of you, but splitting the load
> of review and testing seems to me like it would make sense.
> In any case, thanks to both of you for the efforts you've
> put in to this sort of patch curation -- I think it's really
> important for the project.
The trivial patches tree is still very useful.
The meaning of "misc patches" is almost always "I don't want to send a
separate pull request because this is touching too many areas"
(typically three or more among: qemu-char, SCSI, KVM, x86, and stuff
that I touched and got a Reviewed-by).
5-10% of the "misc patches", instead, correspond to unmaintained
areas---basically the patches that Anthony used to apply directly---but
luckily by now there are very few of those.
In any case, most patches in the "misc patches" pull request are not
trivial. They could very well break something and if they do I
sometimes get to fix them... which is why I'm very happy that someone
else picks up the _really_ trivial patches!
So, the trivial patches tree is still as useful as it has always been,
and I use it myself relatively often for patches outside the areas I
maintain.
Paolo
- [Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into sign bit, (continued)
- [Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into sign bit, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 05/12] target-tricore: Fix new typos, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 03/12] translate-all: Mark map_exec() with the 'unused' attribute, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 01/12] vt82c686: avoid out-of-bounds read, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 06/12] target-arm: Fix typo in comment (seperately -> separately), Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 12/12] vl.c: fix some alignment issues, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 09/12] target-openrisc: bugfix for dec_sys to decode instructions correctly, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 02/12] tests/hd-geo-test.c: Remove unused test_image variable, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 11/12] blizzard: do not depend on VGA internals, Michael Tokarev, 2015/01/15
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15, Peter Maydell, 2015/01/15
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15,
Paolo Bonzini <=