[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into sign bit |
Date: |
Thu, 15 Jan 2015 11:30:42 +0300 |
From: Peter Maydell <address@hidden>
Add a cast in qemu_get_be32() to avoid shifting left into the sign
bit of a signed integer (which is undefined behaviour in C).
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
migration/qemu-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index d2d4007..a7f2a34 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -503,7 +503,7 @@ unsigned int qemu_get_be16(QEMUFile *f)
unsigned int qemu_get_be32(QEMUFile *f)
{
unsigned int v;
- v = qemu_get_byte(f) << 24;
+ v = (unsigned int)qemu_get_byte(f) << 24;
v |= qemu_get_byte(f) << 16;
v |= qemu_get_byte(f) << 8;
v |= qemu_get_byte(f);
--
2.1.4
- [Qemu-trivial] [PULL 00/12] Trivial patches for 2015-01-15, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 07/12] misc: Fix new typos in comments, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 10/12] Makefile: Remove config.status and common.env during 'make distclean', Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 08/12] Do not hang on full PTY, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into sign bit,
Michael Tokarev <=
- [Qemu-trivial] [PULL 05/12] target-tricore: Fix new typos, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 03/12] translate-all: Mark map_exec() with the 'unused' attribute, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 01/12] vt82c686: avoid out-of-bounds read, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 06/12] target-arm: Fix typo in comment (seperately -> separately), Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 12/12] vl.c: fix some alignment issues, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 09/12] target-openrisc: bugfix for dec_sys to decode instructions correctly, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 02/12] tests/hd-geo-test.c: Remove unused test_image variable, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 11/12] blizzard: do not depend on VGA internals, Michael Tokarev, 2015/01/15
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15, Peter Maydell, 2015/01/15