[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 0/4] POWER9 TCG enablements - BCD functions par
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v2 0/4] POWER9 TCG enablements - BCD functions part II |
Date: |
Thu, 24 Nov 2016 12:28:32 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Wed, Nov 23, 2016 at 02:21:41PM -0200, Jose Ricardo Ziviani wrote:
> v2:
> - use div128 and mul64 functions to make code easier to understand
> - fixed int128 neg
> - improved functions bcdcpsgn and bcdsetsgn to do less work
> than necessary
> - rebased on ppc-for-2.9
>
> This serie contains 4 new instructions for POWER9 ISA3.0
>
> bcdcfsq.: Convert signed quadword to packed BCD
> bcdctsq.: Convert packed BCD to signed quadword
> bcdcpsgn.: Copy the sign of a register to another
> bcdsetsgn.: Set the BCD sign according to a preferred sign
Patch 1/4 has some problems, see comments.
Patches 2..4/4 look ok - except that they'll need to be updated for
the recent change I merged from Nikunj (in ppc-for-2.9) which changes
the meaning of CRF_*.
>
> Jose Ricardo Ziviani (4):
> target-ppc: Implement bcdcfsq. instruction
> target-ppc: Implement bcdctsq. instruction
> target-ppc: Implement bcdcpsgn. instruction
> target-ppc: Implement bcdsetsgn. instruction
>
> target-ppc/helper.h | 4 ++
> target-ppc/int_helper.c | 127
> ++++++++++++++++++++++++++++++++++++
> target-ppc/translate/vmx-impl.inc.c | 25 +++++++
> target-ppc/translate/vmx-ops.inc.c | 2 +-
> 4 files changed, 157 insertions(+), 1 deletion(-)
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature