[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 09/10] ppc: Move exception generation code out
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v2 09/10] ppc: Move exception generation code out of line |
Date: |
Wed, 22 Jun 2016 16:57:46 +1000 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jun 21, 2016 at 11:48:54PM +0200, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt <address@hidden>
>
> There's no point inlining this, if you hit the exception case you exit
> anyway, and not inlining saves about 100K of code size (and cache
> footprint).
>
> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
> [clg: removed '__attribute__((noinline))' from original patch ]
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> target-ppc/translate.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 83ec2dd7707b..365fe3d34461 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -283,7 +283,7 @@ void gen_update_current_nip(void *opaque)
> tcg_gen_movi_tl(cpu_nip, ctx->nip);
> }
>
> -static inline void gen_exception_err(DisasContext *ctx, uint32_t excp,
> uint32_t error)
> +static void gen_exception_err(DisasContext *ctx, uint32_t excp, uint32_t
> error)
> {
> TCGv_i32 t0, t1;
> if (ctx->exception == POWERPC_EXCP_NONE) {
> @@ -297,7 +297,7 @@ static inline void gen_exception_err(DisasContext *ctx,
> uint32_t excp, uint32_t
> ctx->exception = (excp);
> }
>
> -static inline void gen_exception(DisasContext *ctx, uint32_t excp)
> +static void gen_exception(DisasContext *ctx, uint32_t excp)
> {
> TCGv_i32 t0;
> if (ctx->exception == POWERPC_EXCP_NONE) {
> @@ -309,7 +309,7 @@ static inline void gen_exception(DisasContext *ctx,
> uint32_t excp)
> ctx->exception = (excp);
> }
>
> -static inline void gen_debug_exception(DisasContext *ctx)
> +static void gen_debug_exception(DisasContext *ctx)
> {
> TCGv_i32 t0;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH v2 02/10] ppc: define a default LPCR value, (continued)
- [Qemu-ppc] [PATCH v2 02/10] ppc: define a default LPCR value, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 03/10] ppc: fix exception model for HV mode, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 04/10] ppc: Fix POWER7 and POWER8 exception definitions, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 05/10] ppc: Fix generation if ISI/DSI vs. HV mode, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 06/10] ppc: Rework generation of priv and inval interrupts, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 07/10] ppc: Add real mode CI load/store instructions for P7 and P8, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 08/10] ppc: Turn a bunch of booleans from int to bool, Cédric Le Goater, 2016/06/21
- [Qemu-ppc] [PATCH v2 09/10] ppc: Move exception generation code out of line, Cédric Le Goater, 2016/06/21
- Re: [Qemu-ppc] [PATCH v2 09/10] ppc: Move exception generation code out of line,
David Gibson <=
- [Qemu-ppc] [PATCH v2 10/10] ppc: Add P7/P8 Power Management instructions, Cédric Le Goater, 2016/06/21