[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] target-ppc: fix hugepage support when using memor

From: Alexander Graf
Subject: Re: [Qemu-ppc] [PATCH] target-ppc: fix hugepage support when using memory-backend-file
Date: Mon, 06 Jul 2015 10:53:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 07/03/15 09:18, David Gibson wrote:
On Thu, Jul 02, 2015 at 03:46:14PM -0500, Michael Roth wrote:
Current PPC code relies on -mem-path being used in order for
hugepage support to be detected. With the introduction of
MemoryBackendFile we can now handle this via:
   -object memory-file-backend,mem-path=...,id=hugemem0 \
   -numa node,id=mem0,memdev=hugemem0

Management tools like libvirt treat the 2 approaches as
interchangeable in some cases, which can lead to user-visible
regressions even for previously supported guest configurations.

Fix these by also iterating through any configured memory
backends that may be backed by hugepages.

Since the old code assumed hugepages always backed the entirety
of guest memory, play it safe an pick the minimum across the
max pages sizes for all backends, even ones that aren't backed
by hugepages.

Cc: address@hidden
Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: David Gibson <address@hidden>

Thanks, applied to ppc-next.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]