[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] target-ppc: fix hugepage support when using memor

From: David Gibson
Subject: Re: [Qemu-ppc] [PATCH] target-ppc: fix hugepage support when using memory-backend-file
Date: Mon, 6 Jul 2015 21:09:31 +1000
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Jul 06, 2015 at 10:53:47AM +0200, Alexander Graf wrote:
> On 07/03/15 09:18, David Gibson wrote:
> >On Thu, Jul 02, 2015 at 03:46:14PM -0500, Michael Roth wrote:
> >>Current PPC code relies on -mem-path being used in order for
> >>hugepage support to be detected. With the introduction of
> >>MemoryBackendFile we can now handle this via:
> >>   -object memory-file-backend,mem-path=...,id=hugemem0 \
> >>   -numa node,id=mem0,memdev=hugemem0
> >>
> >>Management tools like libvirt treat the 2 approaches as
> >>interchangeable in some cases, which can lead to user-visible
> >>regressions even for previously supported guest configurations.
> >>
> >>Fix these by also iterating through any configured memory
> >>backends that may be backed by hugepages.
> >>
> >>Since the old code assumed hugepages always backed the entirety
> >>of guest memory, play it safe an pick the minimum across the
> >>max pages sizes for all backends, even ones that aren't backed
> >>by hugepages.
> >>
> >>Cc: address@hidden
> >>Signed-off-by: Michael Roth <address@hidden>
> >Reviewed-by: David Gibson <address@hidden>
> >
> Thanks, applied to ppc-next.

Hrm.. I see that you've pushed out ppc-next with this patch, but looks
like it hasn't been rebased on latest master.

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

Attachment: pgp43295LcdG1.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]