qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks


From: Eduardo Habkost
Subject: Re: [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks
Date: Fri, 24 May 2019 15:53:44 -0300
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, May 23, 2019 at 06:14:18PM +0200, Markus Armbruster wrote:
> It's nice when QAPI schema modules clearly belong to a single subsystem
> in addition to "QAPI Schema".  misc.json doesn't, and it's grown fat:
> 3000+ lines.  Let's move out some stuff.  Here are a few candidates:
> 
> * Dump (Marc-André)
> 
>   dump-guest-memory, query-dump, DUMP_COMPLETED,
>   query-dump-guest-memory-capability
> 
>   ~200 lines.
> 
> * Machine core (Eduardo, Marcel)
> 
>   query-machines, query-current-machine, 
> 
>   ~60 lines.  Hardly worthwhile from a "let's shrink misc.json" point of
>   view.  Might be worthwhile from a "let's make get_maintainers.pl
>   work".
> 
> * CPUs (Paolo, Richard)
> 
>   query-cpus, query-cpus-fast
> 
>   ~300 lines.  The commands are implemented in cpus.c, which MAINTAINERS
>   covers both under "Main loop" and under "Guest CPU cores (TCG) /
>   Overall".  Neither feels right to me for these QMP commands.

Should it include query-cpu-* (currently on target.json),
and query-hotpluggable-cpus?

> 
> * NUMA (Eduardo)
> 
>   query-memdev, set-numa-node
> 
>   ~200 lines.
> 
> Opinions?
> 
> Additional candidates?

QOM: qom-list, qom-get, qom-set, qom-list-properties, object-add
object-del.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]