[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks |
Date: |
Thu, 23 May 2019 18:14:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
It's nice when QAPI schema modules clearly belong to a single subsystem
in addition to "QAPI Schema". misc.json doesn't, and it's grown fat:
3000+ lines. Let's move out some stuff. Here are a few candidates:
* Dump (Marc-André)
dump-guest-memory, query-dump, DUMP_COMPLETED,
query-dump-guest-memory-capability
~200 lines.
* Machine core (Eduardo, Marcel)
query-machines, query-current-machine,
~60 lines. Hardly worthwhile from a "let's shrink misc.json" point of
view. Might be worthwhile from a "let's make get_maintainers.pl
work".
* CPUs (Paolo, Richard)
query-cpus, query-cpus-fast
~300 lines. The commands are implemented in cpus.c, which MAINTAINERS
covers both under "Main loop" and under "Guest CPU cores (TCG) /
Overall". Neither feels right to me for these QMP commands.
* NUMA (Eduardo)
query-memdev, set-numa-node
~200 lines.
Opinions?
Additional candidates?
- [Qemu-devel] qapi/misc.json is too big, let's bite off a few chunks,
Markus Armbruster <=