[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gv
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa() |
Date: |
Fri, 10 May 2019 12:15:18 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/10/19 11:56 AM, Eduardo Habkost wrote:
> hmp_gva2gpa() calls mon_get_cpu() twice, which is unnecessary.
> Not an actual bug, but this is reported as a defect by Coverity
> Scan (CID 1401346).
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> monitor.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
I was about to send the same patch. ;-)
r~