[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gv
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH] monitor: Call mon_get_cpu() only once at hmp_gva2gpa() |
|
Date: |
Fri, 10 May 2019 20:16:49 +0100 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Richard Henderson (address@hidden) wrote:
> On 5/10/19 11:56 AM, Eduardo Habkost wrote:
> > hmp_gva2gpa() calls mon_get_cpu() twice, which is unnecessary.
> > Not an actual bug, but this is reported as a defect by Coverity
> > Scan (CID 1401346).
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > monitor.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Reviewed-by: Richard Henderson <address@hidden>
>
> I was about to send the same patch. ;-)
I did :-)
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
>
> r~
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK