Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci

[Marc-André Lureau]

Hi

On Thu, May 9, 2019 at 12:09 PM Marc-André Lureau
<address@hidden> wrote:
>
> Hi
>
> On Thu, May 9, 2019 at 11:53 AM Marc-André Lureau
> <address@hidden> wrote:
> >
> > Hi
> >
> > On Thu, May 9, 2019 at 11:25 AM Gerd Hoffmann <address@hidden> wrote:
> > >
> > > On Thu, May 09, 2019 at 10:37:20AM +0200, Marc-André Lureau wrote:
> > > > Hi
> > > >
> > > > On Thu, May 9, 2019 at 8:32 AM Gerd Hoffmann <address@hidden> wrote:
> > > > >
> > > > >   Hi,
> > > > >
> > > > > > +static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = {
> > > > > > +    .base_name = TYPE_VHOST_USER_INPUT_PCI,
> > > > > > +    .generic_name = "vhost-user-input-pci",
> > > > > > +    .transitional_name = "vhost-user-input-pci-transitional",
> > > > > > +    .non_transitional_name = 
> > > > > > "vhost-user-input-pci-non-transitional",
> > > > >
> > > > > virtio-input is virtio 1.0 only, so we don't need these variants.
> > > > > Incremental fix below, if you ack that I can squash it for the pull 
> > > > > req.
> > > > > Or you send a v3 (in case you have other changes pending).
> > > > >
> > > > > cheers,
> > > > >   Gerd
> > > >
> > > > ack, thanks
> > >
> > > Spoke too soon, patch failed tests.
> > > New version (with some virtio-input-host fixes on top) pushed to:
> > >
> > >         https://git.kraxel.org/cgit/qemu/log/?h=testing/vhost-input
> > >
> > > Can you please verify?
> >
> > Looks good, tested successfully.
> > thanks
> >
>
> nack, I tested wrongly, investigating some issue

In your git tree, you removed:
-    .parent = TYPE_VIRTIO_INPUT_PCI,

from vhost_user_input_pci_info, please add it back


-- 
Marc-André Lureau